Samza 1814: consolidate JobNode and JobGraph configuration generation for high and low-level API applications #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or spec and impl layers.
…th-app-runtime-Jul-16-18
… builder in init(); b) spec reader in all other lifecycle methods
…tener, LocalContainerRunner, and SamzaContainerListener
…h- and low-level APIs in YARN and standalone environment
…tputDescriptor; addressed Prateek's comments.
…generation code to support both high- and low-level applications
…y the JobGraph/JobNode code
…-level API applications
…between high and low-level API applications
Contributor
Author
|
@prateekm @vjagadish and @cameronlee314 please take a look. |
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigureGenerator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigureGenerator.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/application/ApplicationDescriptorImpl.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/application/ApplicationDescriptorImpl.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/application/ApplicationDescriptorImpl.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigureGenerator.java
Outdated
Show resolved
Hide resolved
prateekm
requested changes
Sep 19, 2018
Contributor
prateekm
left a comment
prateekm
left a comment
There was a problem hiding this comment.
First pass for some early feedback. Thanks for cleaning this up!
samza-core/src/main/java/org/apache/samza/application/StreamApplicationDescriptorImpl.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/application/ApplicationDescriptorImpl.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/IntermediateStreamPartitionPlanner.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigureGenerator.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/JobNodeConfigureGenerator.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java
Outdated
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/execution/LocalJobPlanner.java
Outdated
Show resolved
Hide resolved
…on generation, not embedded in table. Address review comments
Contributor
Author
|
@prateekm @cameronlee314 could you take a second pass? Thanks! |
cameronlee314
approved these changes
Sep 21, 2018
samza-core/src/main/java/org/apache/samza/application/ApplicationDescriptorImpl.java
Show resolved
Hide resolved
samza-core/src/main/java/org/apache/samza/application/TaskApplicationDescriptorImpl.java
Show resolved
Hide resolved
This was referenced Sep 24, 2018
Contributor
Author
|
Discussed offline with @prateekm and he agreed to merge this in. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-level changes: