Skip to content

Samza-1818: Cleaning up TestRunner Apis to incorporate LegacyTaskApplication and SamzaApplication #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sanil15 wants to merge 5 commits into from
Closed

Samza-1818: Cleaning up TestRunner Apis to incorporate LegacyTaskApplication and SamzaApplication #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ddd9c23
Cleaning up TestRunner Apis to incorporate LegacyTaskApplication and …
Sanil15 Sep 21, 2018
fbb9354
Addressing review
Sanil15 Sep 21, 2018
38c7f77
Fixing merge conflicts
Sanil15 Sep 27, 2018
792f575
Reverting changes
Sanil15 Sep 27, 2018
f0ad565
Reverting the reverted changes
Sanil15 Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions samza-test/src/main/java/org/apache/samza/test/framework/TestRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import org.apache.samza.SamzaException;
import org.apache.samza.application.LegacyTaskApplication;
import org.apache.samza.application.SamzaApplication;
import org.apache.samza.application.StreamApplication;
import org.apache.samza.config.Config;
import org.apache.samza.config.JobConfig;
import org.apache.samza.config.JobCoordinatorConfig;
Expand Down Expand Up @@ -63,7 +62,6 @@
import org.apache.samza.test.framework.system.InMemorySystemDescriptor;
import org.junit.Assert;


/**
* TestRunner provides APIs to set up integration tests for a Samza application.
* Running mode for test is Single container mode
Expand Down Expand Up @@ -102,7 +100,7 @@ private TestRunner() {

/**
* Constructs a new {@link TestRunner} from following components
* @param taskClass represent a class containing Samza job logic extending either {@link StreamTask} or {@link AsyncStreamTask}
* @param taskClass containing Samza job logic extending either {@link StreamTask} or {@link AsyncStreamTask}
*/
private TestRunner(Class taskClass) {
Copy link
Contributor

@prateekm prateekm Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method still required?

this();
Expand All @@ -113,9 +111,9 @@ private TestRunner(Class taskClass) {

/**
* Constructs a new {@link TestRunner} from following components
* @param app samza job implementing {@link StreamApplication}
* @param app a {@link SamzaApplication}
*/
private TestRunner(StreamApplication app) {
private TestRunner(SamzaApplication app) {
this();
Preconditions.checkNotNull(app);
this.app = app;
Expand All @@ -134,11 +132,11 @@ public static TestRunner of(Class taskClass) {
}

/**
* Creates an instance of {@link TestRunner} for High Level/Fluent Samza Api
* @param app samza job implementing {@link StreamApplication}
* Creates an instance of {@link TestRunner} for a {@link SamzaApplication}
* @param app a {@link SamzaApplication}
* @return this {@link TestRunner}
*/
public static TestRunner of(StreamApplication app) {
public static TestRunner of(SamzaApplication app) {
Preconditions.checkNotNull(app);
return new TestRunner(app);
}
Expand Down
2 changes: 0 additions & 2 deletions samza-test/src/test/java/org/apache/samza/test/framework/AsyncStreamTaskIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,4 @@ public void testSamzaJobTimeoutFailureForAsyncTask() {
.addOutputStream(imod, 1)
.run(Duration.ofMillis(1));
}


}
2 changes: 1 addition & 1 deletion samza-test/src/test/java/org/apache/samza/test/framework/StreamTaskIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,4 @@ public void genData(Map<Integer, List<KV>> inputPartitionData, Map<Integer, List
expectedOutputPartitionData.put(i, new ArrayList<Integer>(outputPartition));
}
}
}
}