SANTUARIO-610: Fix NullPointerException in XMLCipher with BC AES GCM #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
approved these changes
Mar 11, 2024
coheigea
added a commit
that referenced
this pull request
Mar 11, 2024
…288) * SANTUARIO-610: Fix NullPointerException in XMLCipher with BC AES GCM NoPadding * Update XMLCipherTest.java --------- Co-authored-by: Benjamin Krahl <krah034@users.noreply.github.com> Co-authored-by: Colm O hEigeartaigh <coheigea@users.noreply.github.com>
coheigea
added a commit
that referenced
this pull request
Dec 17, 2024
…288) * SANTUARIO-610: Fix NullPointerException in XMLCipher with BC AES GCM NoPadding * Update XMLCipherTest.java --------- Co-authored-by: Benjamin Krahl <krah034@users.noreply.github.com> Co-authored-by: Colm O hEigeartaigh <coheigea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed a fix for SANTUARIO-610 when BouncyCastle is at first position in Java security providers and AES GCM NoPadding is used.
When run with BouncyCastle in test class path the code is executed correctly, but fails when
if (data != null)is removed fromXMLCipher.Execute with
bouncycastleprofilemvn test -Dtest=org.apache.xml.security.test.dom.encryption.XMLCipherTest -P bouncycastle