[SANTUARIO-616] enable manual decryption of the EncryptedKey with KeyAgreement #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
approved these changes
Apr 12, 2024
Contributor
coheigea
left a comment
coheigea
left a comment
There was a problem hiding this comment.
LGTM. @seanjmullan please take a look
coheigea
reviewed
Apr 12, 2024
Contributor
coheigea
left a comment
coheigea
left a comment
There was a problem hiding this comment.
Please resolve the conflicts
…curity-java into SANTUARIO-616-legacy-keyagreement-implementation # Conflicts: # src/test/java/org/apache/xml/security/test/dom/encryption/XMLCipherTest.java
Contributor
Author
|
The conflicts are resolved now. |
Member
Sorry been busy with work, etc so the earliest I can get to this and other reviews that are pending my review is end of next week sometime. |
seanjmullan
approved these changes
May 2, 2024
Member
|
LGTM. |
coheigea
pushed a commit
that referenced
this pull request
May 3, 2024
… key agreement (#305) Co-authored-by: RIHTARSIC Joze <joze.rihtarsic@ext.ec.europa.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the KeyAgreement feature incorporating ECDH-ES, X25519, and X448 methods was the introduced to the XMLSEC library. Notably, several software vendors have already developed their own solutions. The objective of this task is to provide an option for bypassing KeyAgreement resolution if the symmetric key has already been supplied to XMLCipher.
See the SANTUARIO-616 for details.