[SANTUARIO-617] remove mgf element in case of rsa-oaep-mgf1p #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
approved these changes
Apr 9, 2024
Contributor
coheigea
left a comment
coheigea
left a comment
There was a problem hiding this comment.
LGTM, @seanjmullan can you take a look?
coheigea
pushed a commit
that referenced
this pull request
Apr 11, 2024
Co-authored-by: RIHTARSIC Joze <joze.rihtarsic@ext.ec.europa.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanuario/xml library have several option to created DOM structure or to serialize EncryptionMethod as example:
XMLCipher.newEncryptionMethod(Element element) {
XMLCipher.EncryptionMethodImpl.getEncryptionMethod()).toElement()
AbstractInternalEncryptionOutputProcessor.createKeyInfoStructure
...
And some of them does not omit MGF element in case of "rsa-oaep-mgf1p"
The purpose of the PR is to add the missing checks and provide regression tests to verify that the MGF element is omitted in the case of "rsa-oaep-mgf1p
For details see the SANTUARIO-617