Fixed KeyValue construction for EC keys #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gamuci
commented
Jun 18, 2024
Gamuci
commented
- The signature KeyValue construction was wrong when an EC key was used. The namespace was declared in the "NamedCurve" element instead of "ECKeyValue". See https://www.w3.org/TR/xmldsig-core1/#sec-ECKeyValue
- This fix is needed in Apache Santuario 3.0.x too.
- The signature KeyValue construction was wrong when an ECC key was used. The namespace was declared in the "NamedCurve" element, instead of "ECKeyValue". (See https://www.w3.org/TR/xmldsig-core1/#sec-ECKeyValue) - The fix is needed in Apache Santuario 3.0.x too.
Contributor
|
@seanjmullan Please take a look, it looks valid |
seanjmullan
approved these changes
Jun 20, 2024
Member
Yes, I approved. |
coheigea
pushed a commit
that referenced
this pull request
Jun 21, 2024
- The signature KeyValue construction was wrong when an ECC key was used. The namespace was declared in the "NamedCurve" element, instead of "ECKeyValue". (See https://www.w3.org/TR/xmldsig-core1/#sec-ECKeyValue) - The fix is needed in Apache Santuario 3.0.x too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.