[SANTUARIO-622] XMLSignatureInput close input stream #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanjmullan
approved these changes
Oct 31, 2024
Member
seanjmullan
left a comment
seanjmullan
left a comment
There was a problem hiding this comment.
I don't think you really need the debug statement. Otherwise, looks good.
Contributor
Author
|
The debug statement is now removed. |
coheigea
approved these changes
Nov 25, 2024
coheigea
pushed a commit
that referenced
this pull request
Dec 17, 2024
* [SANTUARIO-622] XMLSignatureInput close input stream * PR update: remove the unnecessary debug statement --------- Co-authored-by: RIHTARSIC Joze <joze.rihtarsic@ext.ec.europa.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes Resource management enhancements of the inputOctetStreamProxy in the
XMLSignatureInputclass, to mitigate the issue described in [SATUARIO-622].src/main/java/org/apache/xml/security/signature/XMLSignatureInput.java: Modified theupdateOutputStreammethod to use aBufferedInputStreamfor more efficient reading and added a debug log statement for when the input stream is closed. ([src/main/java/org/apache/xml/security/signature/XMLSignatureInput.javaL502-R512](https://github.com/apache/santuario-xml-security-java/pull/406/files#diff-6d3709a5ea6ec527779c8766e2a086461d2ae16bf549f024ff0fbfd9886f4e41L502-R512))src/main/java/org/apache/xml/security/signature/XMLSignatureInput.java: Ensured the input stream is properly closed and theinputOctetStreamProxyreference is removed after reading. ([src/main/java/org/apache/xml/security/signature/XMLSignatureInput.javaL502-R512](https://github.com/apache/santuario-xml-security-java/pull/406/files#diff-6d3709a5ea6ec527779c8766e2a086461d2ae16bf549f024ff0fbfd9886f4e41L502-R512))