Skip to content

[ISSUE #3805] Add ShenyuService and ShenyuDubboService annotations for shenyu-client-apache-dubbo#3838

Merged
loongs-zhang merged 1 commit intoapache:masterfrom
mangoGoForward:feat/add-shenyu-dubbo-service-annotation
Aug 12, 2022
Merged

[ISSUE #3805] Add ShenyuService and ShenyuDubboService annotations for shenyu-client-apache-dubbo#3838
loongs-zhang merged 1 commit intoapache:masterfrom
mangoGoForward:feat/add-shenyu-dubbo-service-annotation

Conversation

@mangoGoForward
Copy link
Copy Markdown
Contributor

Signed-off-by: mango xu.weiKyrie@foxmail.com

Fixes #3805

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@mangoGoForward mangoGoForward force-pushed the feat/add-shenyu-dubbo-service-annotation branch from c0ed347 to a0bab46 Compare August 12, 2022 07:19
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #3838 (bdf9e04) into master (6a08b6c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head bdf9e04 differs from pull request most recent head 8ea4bce. Consider uploading reports for the commit 8ea4bce to get more accurate results

@@             Coverage Diff              @@
##             master    #3838      +/-   ##
============================================
+ Coverage     64.74%   64.76%   +0.01%     
- Complexity     6095     6097       +2     
============================================
  Files           898      898              
  Lines         24708    24708              
  Branches       2240     2240              
============================================
+ Hits          15998    16002       +4     
+ Misses         7304     7300       -4     
  Partials       1406     1406              
Impacted Files Coverage Δ
...ruptor/RegisterClientServerDisruptorPublisher.java 64.70% <0.00%> (+11.76%) ⬆️
...controller/ShenyuClientHttpRegistryController.java 100.00% <0.00%> (+22.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mangoGoForward mangoGoForward force-pushed the feat/add-shenyu-dubbo-service-annotation branch from a0bab46 to bdf9e04 Compare August 12, 2022 08:08
@loongs-zhang
Copy link
Copy Markdown
Member

loongs-zhang commented Aug 12, 2022

please also remove ElementType.METHOD in shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/annotation/ShenyuService.java, because @Service itself does not support annotated in method.

@mangoGoForward mangoGoForward force-pushed the feat/add-shenyu-dubbo-service-annotation branch from bdf9e04 to 8ea4bce Compare August 12, 2022 08:28
@mangoGoForward mangoGoForward marked this pull request as draft August 12, 2022 08:31
…ice` annotations for shenyu-client-apache-dubbo

Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@mangoGoForward mangoGoForward marked this pull request as ready for review August 12, 2022 08:57
@mangoGoForward mangoGoForward force-pushed the feat/add-shenyu-dubbo-service-annotation branch from 8ea4bce to 655a90b Compare August 12, 2022 08:59
@mangoGoForward
Copy link
Copy Markdown
Contributor Author

please also remove ElementType.METHOD in shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/annotation/ShenyuService.java, because @Service itself does not support annotated in method.

Thank you for your patient review, already removed.

@mangoGoForward
Copy link
Copy Markdown
Contributor Author

The CI of build (shenyu-integrated-test-spring-cloud) failed because can not pull openjdk:8-jre-alpine image from docker.io

@loongs-zhang
Copy link
Copy Markdown
Member

The CI of build (shenyu-integrated-test-spring-cloud) failed because can not pull openjdk:8-jre-alpine image from docker.io

ok, I will rerun failed jobs

@loongs-zhang loongs-zhang merged commit efbaaa5 into apache:master Aug 12, 2022
@mangoGoForward mangoGoForward deleted the feat/add-shenyu-dubbo-service-annotation branch August 12, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WeOpen-Star] Add simpler client annotations with @AliasFor

4 participants