build(deps): bump com.puppycrawl.tools:checkstyle from 10.12.1 to 10.12.2

integration-tests/jakarta-ee/src/test/java/org/apache/shiro/testing/jaxrs/NoIniJaxRsIT.java

@@ -38,7 +38,7 @@
 @ExtendWith(ArquillianExtension.class)
 public class NoIniJaxRsIT {
     @Builder
-    private static class Credentials {
+    private static final class Credentials {
         final boolean send;
         final String username;
         final String password;

pom.xml

@@ -557,7 +557,7 @@
                         <dependency>
                             <groupId>com.puppycrawl.tools</groupId>
                             <artifactId>checkstyle</artifactId>
-                            <version>10.12.1</version>
+                            <version>10.12.2</version>
                         </dependency>
                     </dependencies>
                 </plugin>

support/cdi/src/test/java/org/apache/shiro/cdi/AnnotatedTypeWrapperTest.java

@@ -44,17 +44,17 @@ class AnnotatedTypeWrapperTest {
     @RequiresAuthentication
     @RequiresGuest
     @RequiresPermissions("hello")
-    private class Annotated { }
+    private final class Annotated { }
 
     @ShiroSecureAnnotation
-    private class ShiroSecureAnnotated { }
+    private final class ShiroSecureAnnotated { }
 
     @Stateless
-    private class StatelessAnnotated { }
+    private final class StatelessAnnotated { }
 
     @SessionScoped
     @SuppressWarnings("serial")
-    private static class SessionScopedAnnotated implements Serializable { }
+    private static final class SessionScopedAnnotated implements Serializable { }
 
     @Test
     void noAnnotations() {

support/jakarta-ee/src/main/java/org/apache/shiro/ee/cdi/ShiroSessionScopeExtension.java

@@ -46,23 +46,23 @@ public class ShiroSessionScopeExtension implements Extension, Serializable {
 
     @SessionScoped
     @SuppressWarnings("serial")
-    private static class SessionScopedAnnotated implements Serializable { }
+    private static final class SessionScopedAnnotated implements Serializable { }
     @javax.faces.view.ViewScoped
     @SuppressWarnings("serial")
-    private static class FacesViewScopedAnnotated implements Serializable { }
+    private static final class FacesViewScopedAnnotated implements Serializable { }
     @org.omnifaces.cdi.ViewScoped
     @SuppressWarnings("serial")
-    private static class OmniViewScopedAnnotated implements Serializable { }
+    private static final class OmniViewScopedAnnotated implements Serializable { }
 
     @ShiroSessionScoped
     @SuppressWarnings("serial")
-    private static class ShiroSessionScopedAnnotated implements Serializable { }
+    private static final class ShiroSessionScopedAnnotated implements Serializable { }
     @ShiroFacesViewScoped
     @SuppressWarnings("serial")
-    private static class ShiroFacesViewScopedAnnotated implements Serializable { }
+    private static final class ShiroFacesViewScopedAnnotated implements Serializable { }
     @ShiroOmniViewScoped
     @SuppressWarnings("serial")
-    private static class ShiroOmniViewScopedAnnotated implements Serializable { }
+    private static final class ShiroOmniViewScopedAnnotated implements Serializable { }
 
 
     /**

support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/FormAuthenticationFilter.java

@@ -38,7 +38,7 @@ public class FormAuthenticationFilter extends org.apache.shiro.web.filter.authc.
     static final FallbackPredicate NO_PREDICATE = (path, request) -> false;
     private final @Delegate AuthenticationFilterDelegate delegate;
 
-    private class Methods implements MethodsFromFilter {
+    private final class Methods implements MethodsFromFilter {
         @Override
         public Subject getSubject(ServletRequest request, ServletResponse response) {
             return FormAuthenticationFilter.super.getSubject(request, response);

support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/LogoutFilter.java

@@ -33,7 +33,7 @@ public class LogoutFilter extends org.apache.shiro.web.filter.authc.LogoutFilter
     static final String LOGOUT_PREDICATE_ATTR_NAME = "org.apache.shiro.ee.logout-predicate";
     private final @Delegate AuthenticationFilterDelegate delegate;
 
-    private class Methods implements MethodsFromFilter {
+    private final class Methods implements MethodsFromFilter {
         @Override
         public Subject getSubject(ServletRequest request, ServletResponse response) {
             return LogoutFilter.super.getSubject(request, response);

support/jakarta-ee/src/main/java/org/apache/shiro/ee/filters/PassThruAuthenticationFilter.java

@@ -30,7 +30,7 @@
 public class PassThruAuthenticationFilter extends org.apache.shiro.web.filter.authc.PassThruAuthenticationFilter {
     private final @Delegate AuthenticationFilterDelegate delegate;
 
-    private class Methods implements MethodsFromFilter {
+    private final class Methods implements MethodsFromFilter {
         @Override
         public Subject getSubject(ServletRequest request, ServletResponse response) {
             return PassThruAuthenticationFilter.super.getSubject(request, response);

support/jakarta-ee/src/main/java/org/apache/shiro/ee/listeners/IniEnvironment.java

@@ -40,7 +40,7 @@ public class IniEnvironment extends IniWebEnvironment {
     private String otherConfigLocation;
 
     @SuppressWarnings("deprecation")
-    private static class SecurityManagerFactory extends WebIniSecurityManagerFactory {
+    private static final class SecurityManagerFactory extends WebIniSecurityManagerFactory {
         private final Lazy<AesCipherService> cipherService = new Lazy<>(AesCipherService::new);
 
         @Override

support/jakarta-ee/src/test/java/org/apache/shiro/ee/cdi/ShiroScopeContextTest.java

@@ -56,7 +56,7 @@ public class ShiroScopeContextTest {
     private MyBean bean;
     private ShiroScopeContext ctx;
 
-    private static class MyBean implements ViewScoped, Serializable {
+    private static final class MyBean implements ViewScoped, Serializable {
         private static final long serialVersionUID = 1L;
 
         @Override