Skip to content

Conversation

@bmarwell
Copy link
Contributor

Please discuss whether or not this is a breaking change.

From my perspective it is not, feel free to prove me wrong :)

@bmarwell
Copy link
Contributor Author

@fpapon
Copy link
Member

fpapon commented May 7, 2020

@bmhm Can you rebase to resolve conflicts please?

  - Non-Breaking change.
  - Also set the scope to provided. Containers will provide this API.
@bmarwell
Copy link
Contributor Author

bmarwell commented May 8, 2020

@bmhm Can you rebase to resolve conflicts please?

Done, please re-review.

@fpapon fpapon self-requested a review May 8, 2020 09:44
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpapon fpapon merged commit c3f3b31 into apache:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants