Skip to content

Conversation

@lprimak
Copy link
Contributor

@lprimak lprimak commented Apr 12, 2025

…sing leaking security TLs into child threads
fixes #2081

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…sing leaking security TLs into child threads
@lprimak lprimak changed the title bugfix: remove InheriableThreadLocal from ThreadContext as it was cau… [#2081] bugfix: remove InheriableThreadLocal from ThreadContext as it was cau… Apr 12, 2025
@lprimak lprimak self-assigned this Apr 12, 2025
@lprimak lprimak added java Pull requests that update Java code core Core Modules labels Apr 12, 2025
@lprimak lprimak added this to the 2.0.4 milestone Apr 12, 2025
@lprimak lprimak merged commit 03126c4 into apache:main Apr 15, 2025
27 checks passed
@lprimak lprimak deleted the remove-inheriable-thread-local branch May 8, 2025 19:36
@boris-petrov
Copy link
Contributor

I believe this also somewhat resolved https://issues.apache.org/jira/browse/SHIRO-763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core Modules java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Thread-locals are not being cleaned up when Serviets throw exceptions

3 participants