Skip to content

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 1, 2020

Fixes SHIRO-551.

I used StringJoiner instead of StringUtils.ToString, because the dependency to StringUtils is probably not needed anymore since Java 8.

@fpapon fpapon self-requested a review July 4, 2020 20:53
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmhm can you fix the conflicts?

@bmarwell bmarwell requested a review from fpapon July 5, 2020 12:11
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpapon fpapon merged commit 8e3042f into apache:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants