Skip to content

[SHIRO-776] Update JUnit #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmarwell merged 1 commit into from
May 13, 2020
Merged

[SHIRO-776] Update JUnit #237

bmarwell merged 1 commit into from
May 13, 2020

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 12, 2020

  • Removes JUnit 4
  • Adds JUnit 5
  • Adds junit jupiter vintage engine

Needs rebasing after #236

@bmarwell bmarwell requested a review from fpapon May 12, 2020 15:20
@bmarwell
Copy link
Contributor Author

bmarwell commented May 12, 2020

retest this please

fpapon
fpapon approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarwell bmarwell marked this pull request as ready for review May 13, 2020 06:25
@bmarwell bmarwell merged commit fef7188 into apache:master May 13, 2020
@bmarwell bmarwell deleted the SHIRO-776-junit5 branch May 13, 2020 06:40
@bmarwell bmarwell changed the title [SHIRO-777] Update JUnit [SHIRO-776] Update JUnit May 13, 2020
@timtebeek timtebeek mentioned this pull request Mar 1, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdemers bdemers bdemers approved these changes

@fpapon fpapon fpapon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bmarwell @bdemers @fpapon