Fix topn query nil and add more context to err#445
Merged
Conversation
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
3 tasks
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
wu-sheng
approved these changes
May 14, 2024
wu-sheng
changed the title
Contributor
|
Will we cherry-pick this commit to v0.6.x? |
Member
It depends on why this happens. If this is blocking the general use, we should have 0.6.1. Otherwise, it is not in urgent. @lujiajing1126 Do you face anything in testing? |
Contributor
Author
I prefer waiting for 24 hours for future feedback on the error, and regardless of the result, a new patch is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.