Skip to content

[Feature] Add JDK ThreadPoolExecutor plugin(#8743)#146

Merged
wu-sheng merged 10 commits intoapache:mainfrom
Cool-Coding:main
Apr 12, 2022
Merged

[Feature] Add JDK ThreadPoolExecutor plugin(#8743)#146
wu-sheng merged 10 commits intoapache:mainfrom
Cool-Coding:main

Conversation

@Cool-Coding
Copy link
Copy Markdown
Contributor

Add an agent plugin to support JDK ThreadPoolExecutor and its subclasses

  • Add a test case for the new plugin, refer to the doc

  • Update the documentation to include this new feature.
  • Tests(including UT, IT, E2E) are added to verify the new feature.
  • If it's UI related, attach the screenshots below.

ThreadPoolExecutor.submit(Callable)
image

ThreadPoolExecutor.execute(Runnable)
image

ThreadPoolExecutor.submit(Runnable)
image

ScheduledThreadPoolExecutor.submit(Callable)
image

ScheduledThreadPoolExecutor.execute(Runnable)
image

ScheduledThreadPoolExecutor.submit(Runnable)
image

submit(Callable) exception
image

execute(Runnable) exception
image

Comment thread test/plugin/scenarios/jdk-threadpool-scenario/bin/startup.sh
@wu-sheng
Copy link
Copy Markdown
Member

Are you going to create a new one?

@Cool-Coding Cool-Coding reopened this Apr 11, 2022
@Cool-Coding
Copy link
Copy Markdown
Contributor Author

Cool-Coding commented Apr 11, 2022

Are you going to create a new one?

No, I will still use this one. There is a new PR before my PR is merged. I reset my commit and pulled the new commit just now. GitHub closed my PR automatically. I have reopened it.

@wu-sheng
Copy link
Copy Markdown
Member

It seems some test cases fail, please recheck.

@Cool-Coding
Copy link
Copy Markdown
Contributor Author

It seems some test cases fail, please recheck.

I have rechecked it. It seems that it has nothing to do with my modification. I will recheck it again. please take a look at my reply.

@wu-sheng
Copy link
Copy Markdown
Member

Many NPEs happen in the UT, I think you break something. Please recheck.

* it can instruct 'execute' and 'submit' method in 'ThreadPoolExecutor'.
* 'ThreadPoolExecutor' and its subclasses can be instructed.
@Cool-Coding
Copy link
Copy Markdown
Contributor Author

Many NPEs happen in the UT, I think you break something. Please recheck.

I have rechecked it again. There is still one failed that has nothing to do with my modification.

ERROR: 1 dead links found!
[✖] https://twitter.com/ASFSkyWalking → Status: 404

@wu-sheng
Copy link
Copy Markdown
Member

Many NPEs happen in the UT, I think you break something. Please recheck.

I have rechecked it again. There is still one failed that has nothing to do with my modification.

ERROR: 1 dead links found!
[✖] https://twitter.com/ASFSkyWalking → Status: 404

Ignore this. Don't worry.

…ava/org/apache/skywalking/apm/plugin/define/ThreadPoolExecutorInstrumentation.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
Cool-Coding and others added 2 commits April 12, 2022 14:51
…ava/org/apache/skywalking/apm/plugin/define/ThreadPoolExecutorInstrumentation.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
…ava/org/apache/skywalking/apm/plugin/define/ThreadPoolExecutorInstrumentation.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@wu-sheng
Copy link
Copy Markdown
Member

I think this is mostly done. Once this is merged, I will try to release agent 8.10.0 if you don't have more to add in this release.

@wu-sheng wu-sheng merged commit a5ccbca into apache:main Apr 12, 2022
@wu-sheng wu-sheng added this to the 8.10.0 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants