Skip to content

Lock the maven-compiler-plugin version to avoid the warning log#400

Merged
wu-sheng merged 3 commits intoapache:mainfrom
nisiyong:lock-maven-compiler-plugin-version
Nov 29, 2022
Merged

Lock the maven-compiler-plugin version to avoid the warning log#400
wu-sheng merged 3 commits intoapache:mainfrom
nisiyong:lock-maven-compiler-plugin-version

Conversation

@nisiyong
Copy link
Copy Markdown
Contributor

Lock the maven-compiler-plugin version to avoid the warning log when building. the brief changes as follow:

  • fix the test plugin maven archetypes
  • fix all existing test cases
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:dubbo-2.7.x-scenario:jar:5.0.0
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 80, column 21
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng
Copy link
Copy Markdown
Member

This is for test scenarios only, right?

@nisiyong
Copy link
Copy Markdown
Contributor Author

This is for test scenarios only, right?

Yes, all changes are under the test/plugin folder, you could take a look. This is dirty work, but I can't stand the warning.

@wu-sheng wu-sheng added this to the 8.14.0 milestone Nov 28, 2022
@wu-sheng
Copy link
Copy Markdown
Member

  [INFO] Changes detected - recompiling the module!
  [INFO] Compiling 15 source files to /home/runner/work/skywalking-java/skywalking-java/test/plugin/runner-helper/target/classes
  [INFO] -------------------------------------------------------------
  Error:  COMPILATION ERROR : 
  [INFO] -------------------------------------------------------------
  Error:  /home/runner/work/skywalking-java/skywalking-java/test/plugin/runner-helper/src/main/java/org/apache/skywalking/plugin/test/helper/DockerComposeRunningGenerator.java:[56,36] multi-catch statements are not supported in -source 6
    (use -source 7 or higher to enable multi-catch statements)
  Error:  /home/runner/work/skywalking-java/skywalking-java/test/plugin/runner-helper/src/main/java/org/apache/skywalking/plugin/test/helper/ConfigurationImpl.java:[115,38] lambda expressions are not supported in -source 6
    (use -source 8 or higher to enable lambda expressions)
  Error:  /home/runner/work/skywalking-java/skywalking-java/test/plugin/runner-helper/src/main/java/org/apache/skywalking/plugin/test/helper/ConfigurationImpl.java:[170,54] diamond operator is not supported in -source 6

You seem not just updating the test cases, also updated the test tool. Compiling failed.

@nisiyong
Copy link
Copy Markdown
Contributor Author

Okay, the test tool changes will be revert.

@nisiyong nisiyong force-pushed the lock-maven-compiler-plugin-version branch from 31f4aac to c102114 Compare November 29, 2022 15:46
@wu-sheng wu-sheng merged commit df957f9 into apache:main Nov 29, 2022
@nisiyong nisiyong deleted the lock-maven-compiler-plugin-version branch November 29, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants