Skip to content

Add tags mq.message.keys and mq.message.tags for RocketMQ producer span#404

Merged
wu-sheng merged 6 commits intoapache:mainfrom
nisiyong:rocketmq-span-tags
Dec 3, 2022
Merged

Add tags mq.message.keys and mq.message.tags for RocketMQ producer span#404
wu-sheng merged 6 commits intoapache:mainfrom
nisiyong:rocketmq-span-tags

Conversation

@nisiyong
Copy link
Copy Markdown
Contributor

@nisiyong nisiyong commented Dec 2, 2022

RocketMQ message has tags and keys concept.
See https://rocketmq.apache.org/docs/4.x/producer/04concept1#message

  • Add span tag message.tags to help developers identify messages.
  • Add span tag message.keys to help developers search messages by key in the RocketMQ console.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Dec 2, 2022

Isn't keys enough to locate the message? The tracing should take as less messages as possible

@nisiyong
Copy link
Copy Markdown
Contributor Author

nisiyong commented Dec 3, 2022

Isn't keys enough to locate the message?

The keys is indeed enough to locate the message, which is convenient for locating the problem of message loss.
The tags is used to distinguish interrelated messages under the same topic, it is convenient for identifying what type of messages are produced, and the consumer side will filter message with tags, which is useful to help developers know the subscription between provider and consumer, not only topic name. For more explanations see: https://rocketmq.apache.org/docs/4.x/producer/04concept1/#when-to-use-topictag

The tracing should take as less messages as possible

It should follow this principle, now these tags will be ignored when they are blank.

Comment thread apm-sniffer/apm-sdk-plugin/rocketMQ-4.x-plugin/pom.xml Outdated
@wu-sheng wu-sheng added enhancement New feature or request plugin labels Dec 3, 2022
@wu-sheng wu-sheng added this to the 8.14.0 milestone Dec 3, 2022
@nisiyong nisiyong changed the title Add tags message.keys and message.tags for RocketMQ producer span Add tags mq.message.keys and mq.message.tags for RocketMQ producer span Dec 3, 2022
@wu-sheng wu-sheng merged commit a4c3c85 into apache:main Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants