Skip to content

Add kafka-clients 3.x support#429

Merged
wu-sheng merged 3 commits intomainfrom
kafka-plugin-3.2.x
Dec 23, 2022
Merged

Add kafka-clients 3.x support#429
wu-sheng merged 3 commits intomainfrom
kafka-plugin-3.2.x

Conversation

@lujiajing1126
Copy link
Copy Markdown
Contributor

Fix signature change of the intercepted method in kafka-clients 3.2.x

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

Due to the upstream PR apache/kafka#11046, kafka-clients 3.2.x has changed the signature of pollForFetches. The return type is org.apache.kafka.clients.consumer.internals.Fetch now.

This will cause an exception in SW agent 8.13.x

image

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@lujiajing1126 lujiajing1126 added the bug Something isn't working label Dec 23, 2022
@lujiajing1126 lujiajing1126 added this to the 8.14.0 milestone Dec 23, 2022
@lujiajing1126 lujiajing1126 self-assigned this Dec 23, 2022
@wu-sheng
Copy link
Copy Markdown
Member

Clickhouse CI seems failing due to env failing.
I ask @kezhenxu94 to check whether we could use latest ck client lib on maven central.

Comment on lines +28 to +30
3.0.2
3.1.2
3.2.3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are adding supports to 3.x, not just 3.2.x. Please update the PR title.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@lujiajing1126 lujiajing1126 changed the title Add kafka-clients 3.2.x support Add kafka-clients 3.x support Dec 23, 2022
@lujiajing1126
Copy link
Copy Markdown
Contributor Author

Clickhouse CI seems failing due to env failing. I ask @kezhenxu94 to check whether we could use latest ck client lib on maven central.

It seems the artifact issue only exists in 0.3.0, but not 0.3.1

@wu-sheng
Copy link
Copy Markdown
Member

Clickhouse CI seems failing due to env failing. I ask @kezhenxu94 to check whether we could use latest ck client lib on maven central.

It seems the artifact issue only exists in 0.3.0, but not 0.3.1

The issue is, clickhouse lib has dependencies hosts on https://jitpack.io/ somehow, which is down for 2 days.

@wu-sheng wu-sheng added enhancement New feature or request and removed bug Something isn't working labels Dec 23, 2022
@wu-sheng wu-sheng merged commit ea1c204 into main Dec 23, 2022
@wu-sheng wu-sheng deleted the kafka-plugin-3.2.x branch December 23, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants