Skip to content

Uncommented Mircometer Observation CI test#443

Merged
wu-sheng merged 2 commits intoapache:mainfrom
marcingrzejszczak:micrometerObservationCiTest
Jan 26, 2023
Merged

Uncommented Mircometer Observation CI test#443
wu-sheng merged 2 commits intoapache:mainfrom
marcingrzejszczak:micrometerObservationCiTest

Conversation

@marcingrzejszczak
Copy link
Copy Markdown
Contributor

@marcingrzejszczak marcingrzejszczak commented Jan 26, 2023

related to #401

@marcingrzejszczak
Copy link
Copy Markdown
Contributor Author

   Error: ] Some problems were encountered while processing the POMs:
  Error:  'dependencies.dependency.version' for org.apache.skywalking:apm-toolkit-micrometer-1.10:jar is missing. @ line 57, column 22
   @ 
  Error:  The build could not read 1 project -> [Help 1]
  Error:    
  Error:    The project org.apache.skywalking:resttemplate-6.x-scenario:6.5.0 (/home/runner/work/skywalking-java/skywalking-java/test/plugin/scenarios/resttemplate-6.x-scenario/pom.xml) has 1 error
  Error:      'dependencies.dependency.version' for org.apache.skywalking:apm-toolkit-micrometer-1.10:jar is missing. @ line 57, column 22
  Error:  
  Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
  Error:  Re-run Maven using the -X switch to enable full debug logging.
  Error:  
  Error:  For more information about the errors and possible solutions, please read the following articles:
  Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

@wu-sheng any idea why is the sw.version not passed to the build?

@wu-sheng
Copy link
Copy Markdown
Member

The test scenario seems missing some setup.

@marcingrzejszczak
Copy link
Copy Markdown
Contributor Author

I think that the github actions CI setup is strange. The only place I see that sw.version is set is for e2e yaml. e2e is using jdk8 and different setup than the jdk17 based tests for plugins (where you told me to add the resttemplate 6 scenario). So for the latter sw.version is never set...

@marcingrzejszczak
Copy link
Copy Markdown
Contributor Author

Actually, I've decided to hardcode that value, because otherwise we would need to fix the way the plugins tests are ran. We would need to know upfront what the latest release version is and pass it as a property to the plugin

@marcingrzejszczak
Copy link
Copy Markdown
Contributor Author

Now, with the version fixed the test is passing

@wu-sheng wu-sheng added this to the 8.15.0 milestone Jan 26, 2023
@wu-sheng wu-sheng merged commit 8a7fe75 into apache:main Jan 26, 2023
@wu-sheng
Copy link
Copy Markdown
Member

SkyWalking version dependencies should be set like you did.
There are only two styles of this kind of toolkit testing

  1. Your way
  2. Copy all toolkit codes to test scenario. (trace toolkit scenario)

@marcingrzejszczak marcingrzejszczak deleted the micrometerObservationCiTest branch January 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants