Skip to content

Comments

Add MySQLPlugin to plugins#30

Merged
kezhenxu94 merged 1 commit intoapache:masterfrom
tom-pytel:master
Feb 23, 2021
Merged

Add MySQLPlugin to plugins#30
kezhenxu94 merged 1 commit intoapache:masterfrom
tom-pytel:master

Conversation

@tom-pytel
Copy link
Contributor

No description provided.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number.parseInt(process.env.SW_AGENT_MAX_BUFFER_SIZE as string, 10) : 1000,
ignoreSuffix: process.env.SW_IGNORE_SUFFIX ?? '.jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg',
traceIgnorePath: process.env.SW_TRACE_IGNORE_PATH || '',
mysql_sql_parameters_max_length: Math.trunc(Math.max(0, Number(process.env.SW_MYSQL_SQL_PARAMETERS_MAX_LENGTH))) || 512,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the env var to doc please

@tom-pytel
Copy link
Contributor Author

BTW, I've checked packages request, request-promise and koa and as expected they work by default through the underlying http layer. Should such packages be listed in the docs as "supported" or "compatible" because of this?

@kezhenxu94
Copy link
Member

kezhenxu94 commented Feb 22, 2021

Should such packages be listed in the docs as "supported" or "compatible" because of this?

I think the latter saying makes more sense, let's add a column in the supported libraries table

@tom-pytel
Copy link
Contributor Author

tom-pytel commented Feb 22, 2021

I think the latter saying makes more sense, let's add a column in the supported libraries table

Go ahead and add the column how you want and when I test packages I will add them there.

[EDIT] Never mind, have a look how I added this.

@kezhenxu94
Copy link
Member

@tom-pytel can you please also review #29 , since you're adding 2 plugins for 2 different MySQL libs. Also, if possible, add a test case in this PR?

@tom-pytel
Copy link
Contributor Author

I can look into adding tests later, right now fighting with a PostgreSQL plugin. If you can merge this before I get the pg plugin done it will make things less messy, especially with the other mysql2 plugin...

@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Feb 23, 2021
@kezhenxu94 kezhenxu94 merged commit 1b9d8d7 into apache:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants