Merged
Conversation
tom-pytel
force-pushed
the
master
branch
3 times, most recently
from
79b0903 to
804b083
Compare
tom-pytel
force-pushed
the
master
branch
5 times, most recently
from
3a5d54c to
e16767f
Compare
Contributor
Author
|
Ok, I got this mostly done except that some process does not exit (loops trying to exit), can you have a look? EDIT: Am waiting on this to move on to the Entry / Exit span overhaul. |
Contributor
Author
|
I have some important internal fixes waiting on this getting merged, how about I remove the failing test and send it up on a separate branch so that this can get merged without the test and I can push the fixes and the RabbitMQ test can be handled later? |
Member
Good for me. Go ahead. |
kezhenxu94
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will see about doing the test tomorrow if I am feeling masochistic enough...