express uses http wrap explicitly if http disabled#42
Merged
kezhenxu94 merged 1 commit intoapache:masterfrom Mar 26, 2021
Merged
express uses http wrap explicitly if http disabled#42kezhenxu94 merged 1 commit intoapache:masterfrom
kezhenxu94 merged 1 commit intoapache:masterfrom
Conversation
kezhenxu94
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another edge case and simplification. If the http plugin is disabled and a POST to express has a body then a span created in the handler would not be linked as a child to the express Entry span, now fixed. Basically just exported http server response wrapping code which already handled this fine and using that in express since don't really need to duplicate this functionality in express plugin.