Bump up gRPC version, and use its new release repository#65
Merged
wu-sheng merged 7 commits intoapache:masterfrom Dec 2, 2021
Merged
Bump up gRPC version, and use its new release repository#65wu-sheng merged 7 commits intoapache:masterfrom
wu-sheng merged 7 commits intoapache:masterfrom
Conversation
wu-sheng
reviewed
Nov 26, 2021
wu-sheng
reviewed
Nov 26, 2021
wu-sheng
reviewed
Nov 26, 2021
Member
|
A lot of format changes, I can't see they are expected, please make sure you submitted the necessary changes. |
added 2 commits
November 26, 2021 16:01
kezhenxu94
reviewed
Nov 26, 2021
| } | ||
|
|
||
| const stream = this.reporterClient.collect((error, _) => { | ||
| const stream = this.reporterClient.collect(AuthInterceptor(),(error, _) => { |
| ); | ||
| export default function AuthInterceptor() { | ||
| const mata = new grpc.Metadata() | ||
| if(config.authorization){ |
Member
There was a problem hiding this comment.
Please add a space before (, after )
wu-sheng
changed the title
Member
|
@alanlvle can you please also update the license information in this directory https://github.com/apache/skywalking-nodejs/tree/master/dist ? Others look good to me, thank you! |
Contributor
Author
|
@kezhenxu94 Yes, what are the changes? |
Member
|
Generally this part, https://github.com/apache/skywalking-nodejs/blob/master/dist/LICENSE#L211. You need to update the LICENSE file according to the latest dependencies, even dependencies of dependencies, which is required by the ASF and Apache 2.0 License. |
kezhenxu94
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update:
1.grpc update to @grpc/grpc-js
2.update Authentication Method to realize