Skip to content

Comments

add SW_AWSLAMBDA_FLUSH, fix husky again#71

Merged
tom-pytel merged 1 commit intoapache:masterfrom
tom-pytel:master
Feb 23, 2022
Merged

add SW_AWSLAMBDA_FLUSH, fix husky again#71
tom-pytel merged 1 commit intoapache:masterfrom
tom-pytel:master

Conversation

@tom-pytel
Copy link
Contributor

Two things here:

  • Added SW_AWSLAMBDA_FLUSH env var to explicitly enable / disable data flush on AWS Lambda function exit. This is meant for higher throughput functions where flushing after every call could be expensive. Turning off flush may lose spans but should be much more performant. Spans will simply be sent on subsequent invocations of the handler after the process wakes up.
  • Fixed another problem with husky. Started getting the following error on clean install from scoped repo:
npm ERR! command sh -c husky install
npm ERR! .git can't be found (see https://git.io/Jc3F9)

Seems to be typicode/husky#851 which is supposed to be fixed. Someone who understands this piece of software should double check that it is integrated correctly because this is the second problem encountered in just a couple of days.

@tom-pytel tom-pytel requested a review from kezhenxu94 February 23, 2022 13:09
@tom-pytel tom-pytel added bug Something isn't working enhancement New feature or request plugin labels Feb 23, 2022
@tom-pytel tom-pytel added this to the 0.4.0 milestone Feb 23, 2022
@tom-pytel tom-pytel merged commit eb04e51 into apache:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants