Polish the test framework for simplicity of local test#28
Merged
Conversation
Member
kezhenxu94
commented
Jun 30, 2020
kezhenxu94
commented
- Extract as many commonly-used codes as possible
- Rename the test class to a more general one as contributors tend to copy-paste w/o modifying the class name
kezhenxu94
force-pushed
the
test/polish
branch
2 times, most recently
from
27ebd46 to
8ac486d
Compare
- Extract as many commonly-used codes as possible - Rename the test class to a more general one as contributors tend to copy-paste w/o modifying the class name
wu-sheng
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.