Remove imported classes and add ci scripts for plugin import check.#2881
Merged
wu-sheng merged 11 commits intoapache:masterfrom Jun 16, 2019
Merged
Remove imported classes and add ci scripts for plugin import check.#2881wu-sheng merged 11 commits intoapache:masterfrom
wu-sheng merged 11 commits intoapache:masterfrom
Conversation
kezhenxu94
reviewed
Jun 15, 2019
Member
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
License headers should be added.
Yet this is not perfect because one can still use the full qualified class names out of the scopes.
wu-sheng
reviewed
Jun 16, 2019
| } | ||
| } | ||
|
|
||
| stage('Check 3rd-party classes imported') { |
Member
There was a problem hiding this comment.
Named as Check agent plugin instrumentation imports
Member
|
Grant shell to execute right, run commit the shell |
wu-sheng
added
agent
wu-sheng
reviewed
Jun 16, 2019
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Move all shells to tools/check/agent/plugin folder.
wu-sheng
reviewed
Jun 16, 2019
wu-sheng
changed the title
wu-sheng
reviewed
Jun 16, 2019
wu-sheng
reviewed
Jun 16, 2019
wu-sheng
approved these changes
Jun 16, 2019
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
LGTM. @kezhenxu94 @ascrutae please recheck.
kezhenxu94
reviewed
Jun 16, 2019
kezhenxu94
approved these changes
Jun 16, 2019
wu-sheng
approved these changes
Jun 16, 2019
Member
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Imported 3rd-party classes unless JDK or ByteBuddy maybe trigger agent crash. So I remove it. And provide a shell to check it. But the script is very weak.