Skip to content

[PHP-E2E] Support v8#4862

Merged
kezhenxu94 merged 5 commits intoapache:masterfrom
heyanlong:fix-php-e2e-test
Jun 5, 2020
Merged

[PHP-E2E] Support v8#4862
kezhenxu94 merged 5 commits intoapache:masterfrom
heyanlong:fix-php-e2e-test

Conversation

@heyanlong
Copy link
Copy Markdown
Member

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

New feature or improvement

  • PHP-E2E support v8

@wu-sheng wu-sheng requested a review from kezhenxu94 June 5, 2020 03:34
@wu-sheng wu-sheng added test Test requirements about performance, feature or before release. enhancement Enhancement on performance or codes labels Jun 5, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2020

Codecov Report

Merging #4862 into master will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4862      +/-   ##
============================================
- Coverage     51.35%   51.15%   -0.21%     
+ Complexity     2748     2745       -3     
============================================
  Files          1334     1336       +2     
  Lines         28990    29040      +50     
  Branches       3170     3167       -3     
============================================
- Hits          14887    14854      -33     
- Misses        13423    13504      +81     
- Partials        680      682       +2     
Impacted Files Coverage Δ Complexity Δ
...er/core/server/auth/AuthenticationInterceptor.java 0.00% <0.00%> (-61.54%) 0.00% <0.00%> (-3.00%)
...er/sharing/server/ReceiverGRPCHandlerRegister.java 30.76% <0.00%> (-46.16%) 2.00% <0.00%> (-3.00%)
...ap/server/core/server/GRPCHandlerRegisterImpl.java 62.50% <0.00%> (-25.00%) 2.00% <0.00%> (-1.00%)
...r/cluster/plugin/standalone/StandaloneManager.java 80.00% <0.00%> (-20.00%) 3.00% <0.00%> (-1.00%)
...ing/oap/server/library/server/grpc/GRPCServer.java 55.00% <0.00%> (-5.00%) 6.00% <0.00%> (-1.00%)
...lysis/manual/networkalias/NetworkAddressAlias.java 58.53% <0.00%> (-4.88%) 5.00% <0.00%> (-1.00%)
...core/analysis/manual/instance/InstanceTraffic.java 54.00% <0.00%> (-4.00%) 7.00% <0.00%> (ø%)
...in/elasticsearch7/client/ElasticSearch7Client.java 61.11% <0.00%> (-3.71%) 17.00% <0.00%> (-1.00%)
.../agent/core/profile/ProfileTaskChannelService.java 45.05% <0.00%> (-2.20%) 9.00% <0.00%> (ø%)
...er/sharing/server/SharingServerModuleProvider.java 37.50% <0.00%> (-1.79%) 8.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8a65c...8eef080. Read the comment docs.

Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some nits

Comment thread test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/PHPE2E.java Outdated
Comment thread test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/PHPE2E.java Outdated
@kezhenxu94 kezhenxu94 merged commit 305a6b3 into apache:master Jun 5, 2020
@wu-sheng wu-sheng added this to the 8.0.0 milestone Jun 5, 2020
dagmom pushed a commit to brains-platform/skywalking that referenced this pull request Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement on performance or codes test Test requirements about performance, feature or before release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants