[PHP-E2E] Support v8#4862
Merged
kezhenxu94 merged 5 commits intoapache:masterfrom Jun 5, 2020
heyanlong:fix-php-e2e-test
Merged
[PHP-E2E] Support v8#4862kezhenxu94 merged 5 commits intoapache:masterfrom heyanlong:fix-php-e2e-test
kezhenxu94 merged 5 commits intoapache:masterfrom
heyanlong:fix-php-e2e-test
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4862 +/- ##
============================================
- Coverage 51.35% 51.15% -0.21%
+ Complexity 2748 2745 -3
============================================
Files 1334 1336 +2
Lines 28990 29040 +50
Branches 3170 3167 -3
============================================
- Hits 14887 14854 -33
- Misses 13423 13504 +81
- Partials 680 682 +2 Continue to review full report at Codecov.
|
kezhenxu94
reviewed
Jun 5, 2020
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
Looks good to me except for some nits
kezhenxu94
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
New feature or improvement