Skip to content

Support Quasar fiber tracing#4951

Merged
wu-sheng merged 5 commits intoapache:masterfrom
zhaoyuguang:zyg/quasar
Jun 20, 2020
Merged

Support Quasar fiber tracing#4951
wu-sheng merged 5 commits intoapache:masterfrom
zhaoyuguang:zyg/quasar

Conversation

@zhaoyuguang
Copy link
Copy Markdown
Member

Please answer these questions before submitting pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2020

Codecov Report

Merging #4951 into master will decrease coverage by 0.01%.
The diff coverage is 6.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4951      +/-   ##
============================================
- Coverage     51.32%   51.30%   -0.02%     
+ Complexity     2747     2746       -1     
============================================
  Files          1354     1355       +1     
  Lines         29476    29492      +16     
  Branches       3257     3259       +2     
============================================
+ Hits          15128    15131       +3     
- Misses        13624    13637      +13     
  Partials        724      724              
Impacted Files Coverage Δ Complexity Δ
...skywalking/apm/plugin/quasar/FiberInterceptor.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../apm/network/trace/component/ComponentsDefine.java 98.57% <100.00%> (+0.02%) 1.00 <0.00> (ø)
.../agent/core/context/trace/AbstractTracingSpan.java 65.42% <0.00%> (-0.94%) 13.00% <0.00%> (ø%)
...ng/oap/server/core/alarm/provider/RunningRule.java 77.60% <0.00%> (+0.52%) 10.00% <0.00%> (ø%)
...core/analysis/manual/instance/InstanceTraffic.java 58.00% <0.00%> (+4.00%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b1444...26dcbc5. Read the comment docs.

tags:
- {key: http.method, value: GET}
- {key: url, value: 'http://localhost:8080/quasar-scenario/case/ping'}
- operationName: QUASAR/Fiber
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guasar Fiber is not an async bridge?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, main thread is Http entry, async is Fiber and http exit

@wu-sheng wu-sheng added this to the 8.1.0 milestone Jun 20, 2020
@wu-sheng wu-sheng linked an issue Jun 20, 2020 that may be closed by this pull request
4 tasks
@wu-sheng wu-sheng added agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Quasar fiber tracing

2 participants