Skip to content

add python components#5032

Merged
wu-sheng merged 2 commits intoapache:masterfrom
alonelaval:master
Jul 5, 2020
Merged

add python components#5032
wu-sheng merged 2 commits intoapache:masterfrom
alonelaval:master

Conversation

@alonelaval
Copy link
Copy Markdown
Member

@alonelaval alonelaval commented Jul 5, 2020

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • [* ] New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

add Flask plugin

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2020

Codecov Report

Merging #5032 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5032      +/-   ##
============================================
+ Coverage     53.22%   53.28%   +0.05%     
+ Complexity     2972     2971       -1     
============================================
  Files           771     1406     +635     
  Lines         19405    30499   +11094     
  Branches       1916     3392    +1476     
============================================
+ Hits          10329    16252    +5923     
- Misses         8216    13444    +5228     
+ Partials        860      803      -57     
Impacted Files Coverage Δ Complexity Δ
...erver/receiver/envoy/MetricServiceGRPCHandler.java 12.16% <0.00%> (-77.84%) 2.00% <0.00%> (ø%)
...erver/library/client/jdbc/JDBCClientException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 20.75% <0.00%> (-37.15%) 2.00% <0.00%> (ø%)
...skywalking/oap/server/core/alarm/AlarmMessage.java 66.66% <0.00%> (-33.34%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchInsertRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchUpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7UpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ticsearch7/client/ElasticSearch7InsertRequest.java 83.33% <0.00%> (-16.67%) 2.00% <0.00%> (ø%)
...erver/core/analysis/data/MergableBufferedData.java 84.61% <0.00%> (-15.39%) 4.00% <0.00%> (ø%)
...server/core/analysis/worker/AlarmNotifyWorker.java 85.71% <0.00%> (-14.29%) 3.00% <0.00%> (ø%)
... and 957 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1654a0f...c5c8470. Read the comment docs.

Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require server side mapping?

@wu-sheng wu-sheng added this to the 8.1.0 milestone Jul 5, 2020
@alonelaval
Copy link
Copy Markdown
Member Author

Does this require server side mapping?

yes.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Jul 5, 2020

Then you need to update the config file and add the mapping. You only change the component definition.

@kezhenxu94
Copy link
Copy Markdown
Member

Does this require server side mapping?

yes.

@alonelaval you misunderstood the meaning, we don't need server mapping for the two components actually

@alonelaval
Copy link
Copy Markdown
Member Author

Does this require server side mapping?

yes.

@alonelaval you misunderstood the meaning, we don't need server mapping for the two components actually

OK

@wu-sheng wu-sheng added the backend OAP backend related. label Jul 5, 2020
@wu-sheng wu-sheng merged commit e59ba49 into apache:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants