add Tidb provider module. by JaredTan95 · Pull Request #5844 · apache/skywalking

JaredTan95 · 2020-11-14T12:42:44Z

Fix #5754, #5749

Add a e2e test to verify it works.

Closes Transaction is too large when use TiDB as storage #5749.
Update the CHANGES log.

# Conflicts: # CHANGES.md

codecov · 2020-11-14T12:55:57Z

Codecov Report

Merging #5844 (590bea7) into master (e8f30f9) will increase coverage by 0.02%.
The diff coverage is 85.52%.

@@             Coverage Diff              @@
##             master    #5844      +/-   ##
============================================
+ Coverage     51.15%   51.18%   +0.02%     
- Complexity     3476     3486      +10     
============================================
  Files          1656     1659       +3     
  Lines         35577    35650      +73     
  Branches       3905     3910       +5     
============================================
+ Hits          18200    18246      +46     
- Misses        16469    16495      +26     
- Partials        908      909       +1

Impacted Files	Coverage Δ	Complexity Δ
...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java	`14.28% <0.00%> (ø)`	`1.00 <0.00> (ø)`
...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java	`81.81% <81.81%> (ø)`	`6.00 <6.00> (?)`
.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java	`88.00% <88.00%> (ø)`	`9.00 <9.00> (?)`
...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java	`63.38% <100.00%> (+12.67%)`	`13.00 <0.00> (+1.00)`
.../storage/plugin/jdbc/mysql/MySQLStorageConfig.java	`100.00% <100.00%> (ø)`	`1.00 <1.00> (ø)`
...er/storage/plugin/jdbc/tidb/TiDBStorageConfig.java	`100.00% <100.00%> (ø)`	`1.00 <1.00> (?)`
...s/manual/database/DatabaseStatementDispatcher.java	`10.00% <0.00%> (-90.00%)`	`1.00% <0.00%> (-1.00%)`
...skywalking/oap/server/core/analysis/topn/TopN.java	`0.00% <0.00%> (-33.34%)`	`0.00% <0.00%> (-1.00%)`
...r/cluster/plugin/standalone/StandaloneManager.java	`77.77% <0.00%> (-22.23%)`	`3.00% <0.00%> (-1.00%)`
...ng/oap/server/core/analysis/worker/TopNWorker.java	`42.42% <0.00%> (-12.13%)`	`4.00% <0.00%> (-1.00%)`
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f30f9...590bea7. Read the comment docs.

wu-sheng

Seems you missed the license.
I think you accidentally updated the UI submodule?
Please add e2e for TiDB storage provider.

xbkaishui · 2020-11-15T03:52:45Z

Due to tidb not do well on batch delete, is it better we use partition table?
tiflash is suitable for olap related task. do we need integrate it in e2e test case?

wu-sheng · 2020-11-15T11:29:32Z

@JaredTan95 Please resolveconflict.

# Conflicts: # CHANGES.md # oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java

JaredTan95 · 2020-11-15T13:57:33Z

There is some problem creating a new database when there starting with tidb. :-P

kezhenxu94 · 2020-11-18T07:49:35Z

There is some problem creating a new database when there starting with tidb. :-P

Need any help? Feel free to ping me if anything I can help

JaredTan95 · 2020-11-18T12:23:18Z

There is some problem creating a new database when there starting with tidb. :-P

Need any help? Feel free to ping me if anything I can help

Yes,
Thank you first～
There is some problem in e2e test, due to we have not found a way to create sw db during tidb container creating.

wu-sheng · 2020-11-21T08:27:54Z

@kezhenxu94 Anyway to inject an initial container?

kezhenxu94

Tests passed. LGTM except for one nit inline. You may also want to add a case into the ttl case matrix

wu-sheng

Could we add a TTL e2e for tidb too?

JaredTan95 · 2020-11-22T14:43:40Z

Could we add a TTL e2e for tidb too?

added.

wu-sheng

Once e2e passed, this is good for me.

moonsphere and others added 8 commits October 29, 2020 20:24

fix transaction too large error when use TiDB as storage

fe4132a

add CHANGES.md

2953a06

fix typo

4f3e3db

Merge branch 'master' into dev-fix-tdb

5f24f84

Merge branch 'master' into dev-fix-tdb

8b13719

Merge remote-tracking branch 'origin/master' into dev-fix-tdb

546416e

# Conflicts: # CHANGES.md

Merge branch 'master' into dev-fix-tdb

6f832a0

# Conflicts: # CHANGES.md

add tidb storage provider module.

7187c7e

JaredTan95 requested review from kezhenxu94 and wu-sheng and removed request for wu-sheng November 14, 2020 12:43

JaredTan95 added backend OAP backend related. bug Something isn't working and you are sure it's a bug! core feature Core and important feature. Sometimes, break backwards compatibility. labels Nov 14, 2020

JaredTan95 added this to the 8.3.0 milestone Nov 14, 2020

wu-sheng reviewed Nov 14, 2020

View reviewed changes

JaredTan95 added 3 commits November 15, 2020 10:32

add e2e.

c887749

revert ui submodule.

8171ee1

fix license.

0926e4c

wu-sheng reviewed Nov 15, 2020

View reviewed changes

Comment thread ...ain/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java Outdated

JaredTan95 added 3 commits November 15, 2020 12:18

update e2e.

692e552

update e2e.

6dd6562

update e2e.

dd36b36

wu-sheng mentioned this pull request Nov 15, 2020

fix transaction too large error when use TiDB as storage #5754

Closed

Merge remote-tracking branch 'origin/master' into tidb_provider

774d9f6

# Conflicts: # CHANGES.md # oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java

Merge branch 'master' into tidb_provider

c211afd

Merge branch 'master' into tidb_provider

116fba1

kezhenxu94 and others added 2 commits November 22, 2020 10:45

Fix wrong health check test

eb3a582

Merge branch 'master' into tidb_provider

4f64e9d

kezhenxu94 previously approved these changes Nov 22, 2020

View reviewed changes

Comment thread oap-server/server-storage-plugin/storage-tidb-plugin/pom.xml Outdated

kezhenxu94 requested a review from wu-sheng November 22, 2020 03:05

Merge branch 'master' into tidb_provider

fb1352f

wu-sheng reviewed Nov 22, 2020

View reviewed changes

add tidb ttl e2e.

590bea7

JaredTan95 dismissed kezhenxu94’s stale review via 590bea7 November 22, 2020 14:37

wu-sheng approved these changes Nov 22, 2020

View reviewed changes

kezhenxu94 merged commit 8d164d3 into master Nov 22, 2020

kezhenxu94 deleted the tidb_provider branch November 22, 2020 15:28

Conversation

JaredTan95 commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix #5754, #5749

Uh oh!

codecov Bot commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wu-sheng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xbkaishui commented Nov 15, 2020

Uh oh!

wu-sheng commented Nov 15, 2020

Uh oh!

JaredTan95 commented Nov 15, 2020

Uh oh!

kezhenxu94 commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaredTan95 commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wu-sheng commented Nov 21, 2020

Uh oh!

kezhenxu94 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wu-sheng left a comment

Choose a reason for hiding this comment

Uh oh!

JaredTan95 commented Nov 22, 2020

Uh oh!

wu-sheng left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JaredTan95 commented Nov 14, 2020 •

edited

Loading

codecov Bot commented Nov 14, 2020 •

edited

Loading

kezhenxu94 commented Nov 18, 2020 •

edited

Loading

JaredTan95 commented Nov 18, 2020 •

edited

Loading