Support thread pool metric collect#8461
Merged
wu-sheng merged 6 commits intoapache:masterfrom Jan 29, 2022
Merged
Conversation
added 2 commits
January 20, 2022 23:14
Member
|
Hold until apache/skywalking-java#95 merged. |
wu-sheng
reviewed
Jan 24, 2022
wu-sheng
previously approved these changes
Jan 29, 2022
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Generally good. Wait for apache/skywalking-java#95 merged.
wu-sheng
approved these changes
Jan 29, 2022
wankai123
approved these changes
Jan 29, 2022
mrproliu
approved these changes
Jan 29, 2022
Contributor
mrproliu
left a comment
mrproliu
left a comment
There was a problem hiding this comment.
Generally LGTM. I have run the demo and taken a screenshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.