SOLR-17815: Add parameter to regulate for ACORN-based filtering in vector search #3680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/SOLR-17815 # Conflicts: # solr/core/src/java/org/apache/solr/schema/DenseVectorField.java # solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java # solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java # solr/core/src/test/org/apache/solr/search/neural/KnnQParserTest.java
github-actions
bot
added
the
documentation
…e/SOLR-17815 # Conflicts: # solr/CHANGES.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17815
Description
Added the possibility to pass the Lucene filteredSearchThreshold parameter as a Solr Knn query parameter.
Solution
The parameter has been added to the KnnQParser class, and the getKnnVectorQuery method has been adapted to accept this parameter and call the appropriate KnnVectorQuery constructor in Lucene.
Tests
Two tests have been added in DenseVectorFieldTest to check that the getKnnVectorQuery method returns an object with the expected threshold set.
Two tests have been added in KnnQParserTest to check that the new filteredSearchThreshold parameter is correctly parsed and set.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.