Logs: don't add webapp=/solr #3758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove webapp from the context map as well.
github-actions
bot
added
documentation
epugh
reviewed
Oct 12, 2025
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Seems fine. Do we think there is any issues with the webapp being gone on other tools that might consume the data? though I guess it would just be they dont' have taht one key anymore, and sinces it's always /solr....
Contributor
Author
|
Indeed it's possible some tool may need to be updated. But so be it! Targeting 10.0 here. |
dsmiley
added a commit
that referenced
this pull request
Oct 15, 2025
And remove webapp from the context map as well.
dsmiley
added a commit
that referenced
this pull request
Oct 23, 2025
And remove webapp from the context map as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove webapp from the context map as well.
Rationale: we always deploy to /solr -- this is just noise.
No CHANGES.txt/JIRA