SOLR-17931: Remove deprecated ShardRequestTracker.track(). #3773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored collection creation command so it does not use internals of ShardRequestTracker.
dsmiley
reviewed
Oct 15, 2025
Comment on lines
-366
to
-372
| ShardRequest sreq = new ShardRequest(); | ||
| sreq.nodeName = nodeName; | ||
| params.set("qt", ccc.getAdminPath()); | ||
| sreq.purpose = ShardRequest.PURPOSE_PRIVATE; | ||
| sreq.shards = new String[] {baseUrl}; | ||
| sreq.actualShards = sreq.shards; | ||
| sreq.params = params; |
Contributor
Author
There was a problem hiding this comment.
I should have commented in the PR. This is all done by calling shardRequestTracker.sendShardRequest() that then calls ShardHandler. To me, this is all internal to shard handler, there was no good reasons to duplicate this in the command.
| } | ||
|
|
||
| /** Internal structure to track cores to create with the collection. */ | ||
| private record CoreToCreate(String nodeName, ModifiableSolrParams params) {} |
Contributor
There was a problem hiding this comment.
I'm not seeing that this named structure adds any clarity, honestly. But if you think so then ok.
Contributor
Author
There was a problem hiding this comment.
I agree this may be too verbose. I removed it and used a simple map instead.
dsmiley
approved these changes
Oct 16, 2025
psalagnac
added a commit
that referenced
this pull request
Oct 20, 2025
Refactored collection creation command so it does not use internals of ShardRequestTracker, but uses it to submit requests with public methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17931
Refactored collection creation command so it does not use internals of ShardRequestTracker, but uses it to submit requests with public methods.