Skip to content

Conversation

@janhoy
Copy link
Contributor

@janhoy janhoy commented Oct 16, 2025

https://issues.apache.org/jira/browse/SOLR-17908

This targets Solr 10.0 docker release. Will be merged to branches main, branch_10x and branch_10_0.

This will make sure that the 10.x line of Solr releases on Docker use the latest JRE from the start.
Note that Solr 10's minimum java requirement is 21, there will be benefits down the road to be on 25.

@janhoy janhoy requested a review from Copilot October 16, 2025 22:31
@github-actions github-actions bot added documentation Improvements or additions to documentation docker Docker image tool:build labels Oct 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Solr Docker image to use Java 25 instead of Java 21, aligning with the upgrade path for Solr 10. The change involves updating the base Docker image, hardcoding the Java version in the build script, and documenting the new configuration.

Key Changes:

  • Updated Docker base image from eclipse-temurin:21-jre-noble to eclipse-temurin:25-jre-noble
  • Changed Java version reference in build.gradle from dynamically reading libs.versions.java.min.get() to hardcoded '25'
  • Updated documentation to reflect the new Java 25 base image

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc Added documentation specifying the new Docker base image version
solr/docker/build.gradle Changed Java version from dynamic library reference to hardcoded '25'
dev-docs/gradle-help/docker.txt Updated default base image documentation from Java 21 to Java 25

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the dependencies Dependency upgrades label Oct 17, 2025
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janhoy janhoy merged commit 5e210f9 into apache:main Oct 20, 2025
3 of 5 checks passed
@janhoy janhoy deleted the SOLR-17908-docker-25-noble branch October 20, 2025 14:38
janhoy added a commit that referenced this pull request Oct 20, 2025
janhoy added a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency upgrades docker Docker image documentation Improvements or additions to documentation tool:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants