-
Notifications
You must be signed in to change notification settings - Fork 809
SOLR-17960 Remove deprecated TikaLanguageIdentifierUpdateProcessor #3787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| {solr-javadocs}/modules/langid/org/apache/solr/update/processor/LangDetectLanguageIdentifierUpdateProcessorFactory.html[LangDetectLanguageIdentifierUpdateProcessorFactory]::: Identifies the language of a set of input fields using http://code.google.com/p/language-detection. | ||
|
|
||
| {solr-javadocs}/modules/langid/org/apache/solr/update/processor/TikaLanguageIdentifierUpdateProcessorFactory.html[TikaLanguageIdentifierUpdateProcessorFactory]::: Identifies the language of a set of input fields using Tika's LanguageIdentifier. | ||
| {solr-javadocs}/modules/langid/org/apache/solr/update/processor/OpenNLPLangDetectUpdateProcessorFactory.html[OpenNLPLangDetectUpdateProcessorFactory]::: Identifies the language of a set of input fields using OpenNLP's language detection model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned out the ref guide did not list the OpenNLP identifier...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes the deprecated TikaLanguageIdentifierUpdateProcessor which was deprecated in version 9.10. Users are directed to use LangDetectLanguageIdentifierUpdateProcessor or OpenNLPLangDetectUpdateProcessor as alternatives for language detection functionality.
- Removes all TikaLanguageIdentifierUpdateProcessor related classes and test files
- Updates documentation to remove references to Tika language detection
- Updates configuration examples to use LangDetectLanguageIdentifierUpdateProcessor instead
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| major-changes-in-solr-10.adoc | Adds upgrade note about TikaLanguageIdentifierUpdateProcessor removal |
| language-detection.adoc | Removes Tika implementation from documentation and examples |
| update-request-processors.adoc | Replaces Tika processor reference with OpenNLP processor |
| solrconfig.xml | Updates sample configuration to use LangDetect instead of Tika |
| TikaLanguageIdentifierUpdateProcessorFactoryTest.java | Removes test file for deprecated processor |
| LanguageIdentifierUpdateProcessorFactoryTestCase.java | Removes Tika processor chain test setup |
| solrconfig-languageidentifier.xml | Removes Tika processor configuration from test config |
| TikaLanguageIdentifierUpdateProcessorFactory.java | Removes deprecated factory class |
| TikaLanguageIdentifierUpdateProcessor.java | Removes deprecated processor class |
| gradle.lockfile | Removes Tika dependency from lockfile |
| build.gradle | Removes Tika core dependency |
| README.md | Removes Tika dependency documentation |
| CHANGES.txt | Adds changelog entry for removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc
Outdated
Show resolved
Hide resolved
…in-solr-10.adoc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
epugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
https://issues.apache.org/jira/browse/SOLR-17960
This will be merged to
main,branch_10xandbranch_10_0.