SOLR-17962 Move deprecated SolrClient impls (Apache HttpClient) to test-framework #3793
Conversation
solrj-streaming DatabaseMetaDataImpl ZkController ConcurrentUpdateHttp2SolrClient (jetty)
They will eventually be deleted after tests are migrated.
github-actions
bot
added
dependencies
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
I am surprised by how little impact this has on actual Java code!
github-actions
bot
added
the
documentation
…Framework # Conflicts: # solr/modules/extraction/gradle.lockfile
Expose some impls
|
Keeping them in the same package created a split-package situation, which was problematic for javadoc. So I changed "impl" for "apache", and so there are a bunch of import statement changes. I also moved some tests specific to these classes along with them into the tests of the test framework, for at least one reason being to retain package access. I found I needed to make a member or inner class or two public in solrj for this move, which is a good outcome since if someone wants to create their very own variant, we wouldn't want them to do so in whatever package they want, not Solr's. Looks like there's one failing test related to this move. I'll fix and merge this branch tonight. |
…st-framework (#3793) They will eventually be deleted after tests are migrated. Move to package org.apache.solr.client.solrj.apache. Uncovered a couple trivial visibility matters. * ignore ConnectionReuseTest -- we're going to delete soon anyway
…st-framework (#3793) They will eventually be deleted after tests are migrated. Move to package org.apache.solr.client.solrj.apache. Uncovered a couple trivial visibility matters. * ignore ConnectionReuseTest -- we're going to delete soon anyway
2 participants
https://issues.apache.org/jira/browse/SOLR-17962
This is branched from another PR #3792 with a few lingering Apache HttpClient/SolrClient references; ignore those changes here. That PR should be reviewed and merged first, then this.