SOLR-18091: Separate out core specific info into CoreInfoHandler #4084
+453
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
commented
Jan 28, 2026
|
|
||
| @Override | ||
| public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception { | ||
| rsp.setHttpCaching(false); |
Contributor
Author
There was a problem hiding this comment.
Does this request handler need if (AdminHandlersProxy.maybeProxyToNodes(req, rsp, getCoreContainer(req))) { like SystemInfoHandler has? Is that soemthing every class needs?
epugh
changed the title
Contributor
Author
|
@gerlowskija @igiguere you may be interested in this PR with your work on the V2 apis... |
github-actions
bot
added
documentation
Contributor
Author
|
I think this could go to 10x as it turns out the Admin UI, which is the primary consumer, was easy to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18091
Description
Instead of having SystemInfoHandler accessible at two different URLS, and serving different data, just split them and have proper names.
V1: http://localhost:8983/solr/admin/info/system
V2: http://localhost:8983/api/node/system
and
http://localhost:8983/solr/techproducts/admin/info
There appears to be no V2 for the core level
Solution
Make loading pattern clearer. CoreInfoHandler is in ImplicitPlugins.json, while SystemInfoHandler is part of InfoHandler loaded in CoreContainer.
Tests
manual and unit
I still need to check the solr Admin UI to make sure the new /solr/techproducts/admin/info url makes.