[SPARK-14111][SQL] Correct output nullability with constraints for logical plans #11926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith-constraint Conflicts: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala
…ith-constraint3 Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
|
Test build #53997 has finished for PR 11926 at commit
|
Member
Author
|
retest this please. |
|
Test build #54002 has finished for PR 11926 at commit
|
Member
Author
|
retest this please. |
|
Test build #54015 has finished for PR 11926 at commit
|
Member
Author
|
retest this please. |
|
Test build #54024 has finished for PR 11926 at commit
|
Member
Author
|
retest this please. |
|
Test build #54045 has finished for PR 11926 at commit
|
|
Test build #54164 has finished for PR 11926 at commit
|
|
Test build #54283 has finished for PR 11926 at commit
|
Member
Author
|
The failed tests are due to another bug in |
Member
Author
|
Close this and think better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
JIRA: https://issues.apache.org/jira/browse/SPARK-14111
We use output of logical plan as schema. Output nullablity is important and we should keep its correctness.
With constraints and optimization, in fact we will change output nullability of logical plans. But we don't reflect such changes in the output attributes. So the output nullablity is not correct now.
How was this patch tested?
Modified
InferFiltersFromConstraintsSuiteandAnalysisSuite. Existing tests.