[SPARK-14362][SPARK-14406][SQL][Follow-up] DDL Native Support: Drop View and Drop Table #12284
Conversation
| // When ifExists is false, no exception is issued when the table does not exist. | ||
| // Instead, log it as an error message. | ||
| val objectName = if (isView) "View" else "Table" | ||
| logError(s"$objectName '${tableName.quotedString}' does not exist") |
There was a problem hiding this comment.
Why we need to check tableExists at the beginning?
Here, the reason is to avoid issuing a confusing message. Without the change, users might get a confusing error message table 'abc' does not exist, although they issue a command DROP VIEW.
There was a problem hiding this comment.
Should we just let SessionCatalog to log something like Table or View ${name.quotedString} does not exist?
There was a problem hiding this comment.
Sure, we might need to change a couple of messages for it. Let me try it. Thanks!
|
Test build #55470 has finished for PR 12284 at commit
|
|
cc @yhuai @andrewor14 Thanks! |
|
Test build #55489 has finished for PR 12284 at commit
|
|
Test build #55495 has finished for PR 12284 at commit
|
|
Thanks. Merging to master. |
3 participants
What changes were proposed in this pull request?
This PR is to address the comment: #12146 (diff). It removes the function
isViewSupportedfromSessionCatalog. After the removal, we still can capture the user errors if users try to drop a table usingDROP VIEW.How was this patch tested?
Modified the existing test cases