Skip to content

[Spark-14687][Core][SQL][MLlib] Call path.getFileSystem(conf) instead of call FileSystem.get(conf) #12450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lw-lin wants to merge 1 commit into from
Closed

[Spark-14687][Core][SQL][MLlib] Call path.getFileSystem(conf) instead of call FileSystem.get(conf) #12450

lw-lin wants to merge 1 commit into from

Conversation

@lw-lin
Copy link
Contributor

@lw-lin lw-lin commented Apr 17, 2016

What changes were proposed in this pull request?

  • replaced FileSystem.get(conf) calls with path.getFileSystem(conf)

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Apr 17, 2016

Test build #56044 has finished for PR 12450 at commit feefa8d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Apr 17, 2016
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
dataFrameBuilder: Array[String] => DataFrame) extends Source with Logging {

private val fs = FileSystem.get(sqlContext.sparkContext.hadoopConfiguration)
private val fs = new Path(path).getFileSystem(sqlContext.sparkContext.hadoopConfiguration)
Copy link
Member

@srowen srowen Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM pending tests. I suppose this could even be fetched in the one place it's used later during the method call rather than hold on to a reference, but, I can't recall a specific reason it's bad to hold onto a FileSystem handle, so, leave it as you've done I think.

@srowen
Copy link
Member

srowen commented Apr 17, 2016

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Apr 17, 2016

Test build #56051 has finished for PR 12450 at commit feefa8d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lw-lin
Copy link
Contributor Author

lw-lin commented Apr 18, 2016 •
edited
Loading

Some flaky tests -- not caused by this PR.

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Apr 18, 2016

Test build #56077 has finished for PR 12450 at commit feefa8d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lw-lin
Copy link
Contributor Author

lw-lin commented Apr 19, 2016 •
edited
Loading

Some flaky tests -- not caused by this PR.

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Apr 19, 2016

Test build #56175 has finished for PR 12450 at commit feefa8d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 17db4bf Apr 20, 2016
@srowen
Copy link
Member

srowen commented Apr 20, 2016

Merged to master

@lw-lin
Copy link
Contributor Author

lw-lin commented Apr 20, 2016

@srowen thank you for the review & merging :-)

@lw-lin lw-lin deleted the fix-fs-get branch April 20, 2016 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lw-lin @SparkQA @srowen