Skip to content

[SPARK-14838][SQL] Set default size for ObjecType to avoid failure when estimating sizeInBytes in ObjectProducer #12599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 10 commits into from
Closed

[SPARK-14838][SQL] Set default size for ObjecType to avoid failure when estimating sizeInBytes in ObjectProducer #12599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
84207c7
Skip automatically broadcast a plan when it contains ObjectProducer.
viirya Apr 22, 2016
8e0541c
Add test.
viirya Apr 22, 2016
bb9dd6f
Different approach that implements statistices in SerializeFromObject.
viirya Apr 22, 2016
9d2033f
Revert unused import.
viirya Apr 22, 2016
4b5f66d
Simplify condition check.
viirya Apr 22, 2016
dcd6056
Instead Long.MaxValue, trying to find an underlying logical plan that…
viirya Apr 22, 2016
3ff11a1
Remove wrong comment.
viirya Apr 22, 2016
6b6c12d
Set default size for ObjectType.
viirya Apr 23, 2016
c26c3bd
Correct test name.
viirya Apr 24, 2016
471d9ab
Remove unnecessary import.
viirya Apr 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ private[sql] object ObjectType extends AbstractDataType {
* outside of the execution engine.
*/
private[sql] case class ObjectType(cls: Class[_]) extends DataType {
override def defaultSize: Int =
throw new UnsupportedOperationException("No size estimation available for objects.")
override def defaultSize: Int = 4096

def asNullable: DataType = this

Expand Down
23 changes: 23 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,29 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
// Make sure the generated code for this plan can compile and execute.
checkDataset(wideDF.map(_.getLong(0)), 0L until 10 : _*)
}

test("SPARK-14838: estimating sizeInBytes in operators with ObjectProducer shouldn't fail") {
val dataset = Seq(
(0, 3, 54f),
(0, 4, 44f),
(0, 5, 42f),
(1, 3, 39f),
(1, 5, 33f),
(1, 4, 26f),
(2, 3, 51f),
(2, 5, 45f),
(2, 4, 30f)
).toDF("user", "item", "rating")

val actual = dataset
.select("user", "item")
.as[(Int, Int)]
.groupByKey(_._1)
.mapGroups { case (src, ids) => (src, ids.map(_._2).toArray) }
.toDF("id", "actual")

dataset.join(actual, dataset("user") === actual("id")).collect()
}
}

case class OtherTuple(_1: String, _2: Int)
Expand Down