[SPARK-11559] [MLlib] Make runs no effect in mllib.KMeans
#12608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #56695 has finished for PR 12608 at commit
|
| * This function has no effect since Spark 2.0.0. | ||
| */ | ||
| @Since("1.4.0") | ||
| @deprecated("Support for runs is deprecated. This param will have no effect in 2.0.0.", "1.6.0") |
Member
There was a problem hiding this comment.
isn't it better to keep the @deprecated?
Contributor
Author
There was a problem hiding this comment.
@deprecated means it take effect but not recommend to use, but in this PR we will make it no effect.
Member
|
I'll take a look |
| (default: None) | ||
| """ | ||
| if runs != 1: | ||
| warnings.warn( |
Member
There was a problem hiding this comment.
I'd keep a warning, though you can remove the word "deprecated"
Member
|
Member
|
That's all. Thanks for separating this out. |
|
Test build #56997 has finished for PR 12608 at commit
|
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We deprecated
runsof mllib.KMeans in Spark 1.6 (SPARK-11358). In 2.0, we will make it no effect (with warning messages). We did not removesetRuns/getRunsfor better binary compatibility.This PR change
runswhich are appeared at the public API. Usage inside ofKMeans.runAlgorithm()will be resolved at #10806.How was this patch tested?
Existing unit tests.
cc @jkbradley