Skip to content

[SPARK-15172][ML] Explicitly tell user initial coefficients is ignored when size mismatch happened in LogisticRegression #12948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dding3 wants to merge 3 commits into from
Closed

[SPARK-15172][ML] Explicitly tell user initial coefficients is ignored when size mismatch happened in LogisticRegression #12948

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54cfaed
Improve LogisticRegression warning message
May 6, 2016
f9b88de
fix Scala style tests error
May 7, 2016
1b33456
fix scala style test error
May 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,10 @@ class LogisticRegression @Since("1.2.0") (
Vectors.zeros(if ($(fitIntercept)) numFeatures + 1 else numFeatures)

if (optInitialModel.isDefined && optInitialModel.get.coefficients.size != numFeatures) {
val vec = optInitialModel.get.coefficients
val vecSize = optInitialModel.get.coefficients.size
logWarning(
s"Initial coefficients provided $vec did not match the expected size $numFeatures")
s"Initial coefficients will be ignored!! As its size $vecSize did not match the " +
s"expected size $numFeatures")
}

if (optInitialModel.isDefined && optInitialModel.get.coefficients.size == numFeatures) {
Expand Down