[SPARK-15657][SQL] RowEncoder should validate the data type of input object #13401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #59629 has finished for PR 13401 at commit
|
|
|
||
| val code = s""" | ||
| ${input.code} | ||
| ${ctx.javaType(dataType)} ${ev.value} = ${ctx.defaultValue(dataType)}; |
Contributor
Author
There was a problem hiding this comment.
This is intentional, we can't cast an object to int directly, but have to cast to boxed int first.
|
Test build #59944 has finished for PR 13401 at commit
|
|
Test build #59968 has finished for PR 13401 at commit
|
Contributor
|
LGTM, merging to master and branch-2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 5, 2016
…object ## What changes were proposed in this pull request? This PR improves the error handling of `RowEncoder`. When we create a `RowEncoder` with a given schema, we should validate the data type of input object. e.g. we should throw an exception when a field is boolean but is declared as a string column. This PR also removes the support to use `Product` as a valid external type of struct type. This support is added at #9712, but is incomplete, e.g. nested product, product in array are both not working. However, we never officially support this feature and I think it's ok to ban it. ## How was this patch tested? new tests in `RowEncoderSuite`. Author: Wenchen Fan <wenchen@databricks.com> Closes #13401 from cloud-fan/bug. (cherry picked from commit 30c4774) Signed-off-by: Cheng Lian <lian@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR improves the error handling of
RowEncoder. When we create aRowEncoderwith a given schema, we should validate the data type of input object. e.g. we should throw an exception when a field is boolean but is declared as a string column.This PR also removes the support to use
Productas a valid external type of struct type. This support is added at #9712, but is incomplete, e.g. nested product, product in array are both not working. However, we never officially support this feature and I think it's ok to ban it.How was this patch tested?
new tests in
RowEncoderSuite.