[SPARK-16030] [SQL] Allow specifying static partitions when inserting to data source tables #13746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to data source tables
| Row(17, 18, 19, 20) :: | ||
| Row(21, 22, 23, 24) :: | ||
| Row(25, 26, 27, 28) :: Nil | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
We also need this test for hive format tables. I will add that in a separate PR.
|
Test build #60737 has finished for PR 13746 at commit
|
Contributor
|
This is ok for 2.0, but for something like this we should write it in a way so the rewriting logic can be unit tested without end-to-end suites. |
Contributor
|
Actually can you try do it in this? I worry similar to past pull requests we will never revisit and the code will just look like this 2 years from now. |
| // dynamic_partitioning_columns are partitioning columns that do not assigned | ||
| // values in the PARTITION clause (e.g. c in the above example). | ||
| case i @ logical.InsertIntoTable( | ||
| l @ LogicalRelation(t: HadoopFsRelation, _, _), parts, query, overwrite, false) |
Contributor
There was a problem hiding this comment.
and don't use t or i here either ...
|
Test build #60760 has finished for PR 13746 at commit
|
Contributor
Author
|
Closing this. #13769 is the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the static partition support to INSERT statement when the target table is a data source table.
How was this patch tested?
New tests in
InsertSuite