[SPARK-16033][SQL] insertInto() can't be used together with partitionBy() #13747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| if (partitioningColumns.isDefined) { | ||
| throw new AnalysisException( | ||
| "insertInto() can't be used together with partitionBy(). " + | ||
| "Partition columns are defined by the table into which is being inserted." |
Contributor
There was a problem hiding this comment.
Mention that partitionBy is not needed?
|
Test build #60736 has finished for PR 13747 at commit
|
Contributor
|
LGTM. Merging to master and branch 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
…By() ## What changes were proposed in this pull request? When inserting into an existing partitioned table, partitioning columns should always be determined by catalog metadata of the existing table to be inserted. Extra `partitionBy()` calls don't make sense, and mess up existing data because newly inserted data may have wrong partitioning directory layout. ## How was this patch tested? New test case added in `InsertIntoHiveTableSuite`. Author: Cheng Lian <lian@databricks.com> Closes #13747 from liancheng/spark-16033-insert-into-without-partition-by. (cherry picked from commit 10b6714) Signed-off-by: Yin Huai <yhuai@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When inserting into an existing partitioned table, partitioning columns should always be determined by catalog metadata of the existing table to be inserted. Extra
partitionBy()calls don't make sense, and mess up existing data because newly inserted data may have wrong partitioning directory layout.How was this patch tested?
New test case added in
InsertIntoHiveTableSuite.