Skip to content

Conversation

@jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Currently in the log and UI display, only on-heap storage memory is calculated and displayed,

16/06/27 13:41:52 INFO MemoryStore: Block rdd_5_0 stored as values in memory (estimated size 17.8 KB, free 665.9 MB)

untitled

With SPARK-13992 off-heap memory is supported for data persistence, so here change to also take off-heap storage memory into consideration.

How was this patch tested?

Unit test and local verification.

@SparkQA
Copy link

SparkQA commented Jun 27, 2016

Test build #61291 has finished for PR 13920 at commit e3194bd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

@andrewor14 @JoshRosen would you please help to review this patch, thanks a lot.

@JoshRosen
Copy link
Contributor

Sorry for the delay in reviewing; I've been super busy and stuff has slipped through the cracks. LGTM because this looks like a net improvement over what we have today. In the longer term I think that it might be slightly confusing to combine both on- and off-heap storage memory into a single total in the UI, but we can always deal with that later if it turns out to be a problem.

Let me quickly re-test this to make sure that it still compiles and passes tests, then I'll merge it if Jenkins approves.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 25, 2016

Test build #62837 has finished for PR 13920 at commit e3194bd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in f5ea7fe Jul 25, 2016
@jerryshao
Copy link
Contributor Author

Thanks a lot @JoshRosen .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants