[SPARK-17587][PYTHON][MLLIB] SparseVector __getitem__ should follow __getitem__ contract #15144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #65582 has finished for PR 15144 at commit
|
Member
|
LGTM! |
Member
|
It looks like |
Member
Author
|
@BryanCutler Sure, here you are. Actually both Note: Technically speaking this can is a breaking change if someone expects On a side note it would be nice to support slice and iteration over rows as well but I still hope there is a chance for doing something with SPARK-16626. |
|
Test build #65608 has finished for PR 15144 at commit
|
Member
|
test this please |
|
Test build #66292 has finished for PR 15144 at commit
|
Member
|
LGTM, merging with master and branch-2.0 |
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2016
…_getitem__ contract ## What changes were proposed in this pull request? Replaces` ValueError` with `IndexError` when index passed to `ml` / `mllib` `SparseVector.__getitem__` is out of range. This ensures correct iteration behavior. Replaces `ValueError` with `IndexError` for `DenseMatrix` and `SparkMatrix` in `ml` / `mllib`. ## How was this patch tested? PySpark `ml` / `mllib` unit tests. Additional unit tests to prove that the problem has been resolved. Author: zero323 <zero323@users.noreply.github.com> Closes #15144 from zero323/SPARK-17587. (cherry picked from commit d8399b6) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces
ValueErrorwithIndexErrorwhen index passed toml/mllibSparseVector.__getitem__is out of range. This ensures correct iteration behavior.Replaces
ValueErrorwithIndexErrorforDenseMatrixandSparkMatrixinml/mllib.How was this patch tested?
PySpark
ml/mllibunit tests. Additional unit tests to prove that the problem has been resolved.