[SPARK-17736] [Documentation][SparkR] [Update R README for rmarkdown,… #15309
Conversation
|
Test build #66154 has finished for PR 15309 at commit
|
|
LGTM |
|
These should be rolled into the command above right? |
docs/README.md
Outdated
| @@ -21,6 +21,8 @@ installed. Also install the following libraries: | |||
| # Following is needed only for generating API docs | |||
| $ sudo pip install sphinx | |||
| $ sudo Rscript -e 'install.packages(c("knitr", "devtools", "roxygen2", "testthat"), repos="http://cran.stat.ucla.edu/")' | |||
| $ sudo Rscript -e 'install.packages(c("rmarkdown"), repos="http://cran.stat.ucla.edu/")' | |||
| $ sudo pip install pandoc pandoc-citeproc | |||
There was a problem hiding this comment.
I think this should be
sudo apt-get install pandoc pandoc-citeproc
on Ubuntu
There was a problem hiding this comment.
(And I say this without knowing much about it --) Isn't this a Python package? would it be preferable to manage via pip if so, since that's cross-platform I think? does the Ubuntu package just install the same thing?
There was a problem hiding this comment.
@felixcheung i agree, if we are installing manually on Ubuntu/Debain we need to install using below command
sudo apt-get install pandoc pandoc-citeproc
similarly for
Fedora/Red Hat: sudo yum install pandoc
Arch: sudo pacman -S pandoc
Mac OS X with Homebrew: brew install pandoc pandoc-citeproc Caskroom/cask/mactex
Machine with Haskell: cabal-install pandoc
@srowen
TTBOMK, as it's python package, it can be manage via pip also
https://pypi.python.org/pypi/pypandoc
There was a problem hiding this comment.
pandoc itself is not a python package but it appears the python package pypandoc manages it.
"pypandoc already includes pandoc (and pandoc_citeproc) in it’s prebuilt package."
so maybe we should sudo pip install pypandoc instead?
There was a problem hiding this comment.
+1 on just keeping sudo pip install pypandoc
There was a problem hiding this comment.
I agree with that, but, now we still have two additional commands here, when they can just be packages installed by the commands above. That was my earlier point.
jagadeesanas2
force-pushed
the
SPARK-17736
branch
from
ac6a8c4 to
2870391
Compare
|
Test build #66240 has finished for PR 15309 at commit
|
|
While we are at it, we can merge pypandoc with above too?
|
|
above means, your suggesting like this..? |
jagadeesanas2
force-pushed
the
SPARK-17736
branch
from
2870391 to
5f251a2
Compare
|
Test build #66250 has finished for PR 15309 at commit
|
|
Merged to master/2.0 |
## What changes were proposed in this pull request? To build R docs (which are built when R tests are run), users need to install pandoc and rmarkdown. This was done for Jenkins in ~~[SPARK-17420](https://issues.apache.org/jira/browse/SPARK-17420)~~ … pandoc] Author: Jagadeesan <as2@us.ibm.com> Closes #15309 from jagadeesanas2/SPARK-17736. (cherry picked from commit a27033c) Signed-off-by: Sean Owen <sowen@cloudera.com>
4 participants
What changes were proposed in this pull request?
To build R docs (which are built when R tests are run), users need to install pandoc and rmarkdown. This was done for Jenkins in
SPARK-17420… pandoc]